FOnlineSessionLive leaves inconsistent state when FindSessions or CreateSession fail.

FOnlineSessionLive::CreateSession creates the session early into the method. Later, the method can fail but the session and is never cleared up (see the various catch statements in the tasks which only Trigger the delegates).

This seems to also occur in FOnlineSessionPS4::CreateSession as well. CreateSession creates a session then queues a FOnlineAsyncTaskPS4SessionCreate. This task can exit early (due to failure), but nothing clears the session.

This means the sessions will persist in the TArray<FNamedOnlineSessions> Sessions member.

Similarly, FOnlineSessionsLive::FindSessions also leaves bad state. This could be fixed by either clearing CurrentSessionSearch or changing the conditional in the beginning to properly check that another search isn't in progress (OR instead of AND):

if(!CurrentSessionSearch.IsValid() || SearchSettings->SearchState != EOnlineAsyncTaskState::InProgress)

This doesn't appear to be an issue for FOnlineSessionsPS4::FindSessions.

N/A